PragmaTwice commented on code in PR #3053:
URL: https://github.com/apache/kvrocks/pull/3053#discussion_r2225077837
##########
x.py:
##########
@@ -129,6 +129,11 @@ def build(dir: str, jobs: Optional[int], ninja: bool,
unittest: bool, compiler:
os.makedirs(dir, exist_ok=True)
cmake_options = ["-DCMAKE_BUILD_TYPE=RelWithDebInfo"]
+
+ import platform
+ if platform.machine() == 'riscv64':
+ cmake_options += ["-DENABLE_LUAJIT=OFF", "-DENABLE_LUA=ON"]
+
Review Comment:
Two problems here:
- `-DENABLE_LUA=ON` is useless and can be removed.
- We can move this logic to `CMakeLists.txt`, e.g.
```
if(CMAKE_SYSTEM_PROCESSOR MATCHES "riscv64")
set(ENABLE_LUAJIT OFF)
endif()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
