PragmaTwice commented on code in PR #3075:
URL: https://github.com/apache/kvrocks/pull/3075#discussion_r2244397849
##########
src/cluster/replication.cc:
##########
@@ -654,11 +678,18 @@ ReplicationThread::CBState
ReplicationThread::incrementBatchLoopCB(bufferevent *
// master would send the ping heartbeat packet to check whether the
slave was alive or not,
// don't write ping to db here.
if (data_written) {
- sendReplConfAck(bev);
+ sendReplConfAck(bev, force_ack);
}
return CBState::AGAIN;
}
+ if (bulk_string == "_getack") {
+ // master would send the _getack command to the master to get
acknowledgment
+ // don't write _getack to db here.
+ force_ack = true;
Review Comment:
Good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
