SharonIV0x86 commented on code in PR #3163:
URL: https://github.com/apache/kvrocks/pull/3163#discussion_r2334228889
##########
src/commands/cmd_tdigest.cc:
##########
@@ -371,5 +415,6 @@ REDIS_REGISTER_COMMANDS(TDigest,
MakeCmdAttr<CommandTDigestCreate>("tdigest.crea
MakeCmdAttr<CommandTDigestMin>("tdigest.min", 2,
"read-only", 1, 1, 1),
MakeCmdAttr<CommandTDigestQuantile>("tdigest.quantile", -3, "read-only", 1, 1,
1),
MakeCmdAttr<CommandTDigestReset>("tdigest.reset", 2,
"write", 1, 1, 1),
- MakeCmdAttr<CommandTDigestMerge>("tdigest.merge", -4,
"write", GetMergeKeyRange));
+ MakeCmdAttr<CommandTDigestMerge>("tdigest.merge", -4,
"write", GetMergeKeyRange),
+ MakeCmdAttr<CommandTDigestCDF>("tdigest.cdf", -4,
"write", 1, 1, 1));
Review Comment:
Yes, i will work on it, i was unsure about how the command registration
works and what exactly those parameters do in the ``MakeCmdAttr`` so it will be
helpful if you could explain it in a little detail.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
