mapleFU commented on code in PR #3170:
URL: https://github.com/apache/kvrocks/pull/3170#discussion_r2347745363
##########
src/config/config.cc:
##########
@@ -307,6 +306,10 @@ Config::Config() {
{"rocksdb.max_compaction_bytes", false, new
Int64Field(&rocks_db.max_compaction_bytes, 0, 0, INT64_MAX)},
{"rocksdb.sst_file_delete_rate_bytes_per_sec", false,
new Int64Field(&rocks_db.sst_file_delete_rate_bytes_per_sec, 0, 0,
INT64_MAX)},
+ {"rocksdb.periodic_compaction_seconds", false,
+ new UInt64Field(&rocks_db.periodic_compaction_seconds, UINT64_MAX - 1,
0, UINT64_MAX)},
+ {"rocksdb.ttl", false, new UInt64Field(&rocks_db.ttl, UINT64_MAX - 1, 0,
UINT64_MAX)},
Review Comment:
Can we add two constant DefaultTtl and DefaultPeriodicCompSecs? `UINT64_MAX
- 1` seems two magic numbers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
