mapleFU commented on code in PR #3195:
URL: https://github.com/apache/kvrocks/pull/3195#discussion_r2370794559
##########
src/storage/redis_db.cc:
##########
@@ -183,17 +183,15 @@ rocksdb::Status Database::MDel(engine::Context &ctx,
const std::vector<Slice> &k
std::vector<rocksdb::Status> statuses(slice_keys.size());
std::vector<rocksdb::PinnableSlice> pin_values(slice_keys.size());
- storage_->MultiGet(ctx, ctx.GetReadOptions(), metadata_cf_handle_,
slice_keys.size(), slice_keys.data(),
+ storage_->MultiGet(ctx, ctx.DefaultMultiGetOptions(), metadata_cf_handle_,
slice_keys.size(), slice_keys.data(),
pin_values.data(), statuses.data());
for (size_t i = 0; i < slice_keys.size(); i++) {
if (!statuses[i].ok() && !statuses[i].IsNotFound()) return statuses[i];
if (statuses[i].IsNotFound()) continue;
Metadata metadata(kRedisNone, false);
- // Explicit construct a rocksdb::Slice to avoid the implicit conversion
from
- // PinnableSlice to Slice.
- auto s = metadata.Decode(rocksdb::Slice(pin_values[i].data(),
pin_values[i].size()));
+ auto s = metadata.Decode(pin_values[i]);
Review Comment:
> Pass PinnableSlice directly instead of make copy before passed by value
when calling Metadata::Decode
@PragmaTwice I think this might because afraid of `Slice*` which changes the
value internal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
