git-hulk commented on PR #3228: URL: https://github.com/apache/kvrocks/pull/3228#issuecomment-3418052589
@hll1213181368 Thanks for your good catch. It's a design intent to use `0` to remove the rate limiter. But it now doesn't take effect, indeed. I'm good to change the range to disallow the zero value since the rate limiter also doesn't support using zero value in bytes_in_second. And this won't break the previous behavior since it will panic if users set zero via the configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
