xuzifu666 commented on code in PR #3134:
URL: https://github.com/apache/kvrocks/pull/3134#discussion_r2418739594
##########
src/types/redis_bitmap.cc:
##########
@@ -554,7 +554,9 @@ rocksdb::Status Bitmap::BitOp(engine::Context &ctx,
BitOpFlags op_flag, const st
for (uint64_t i = 0; i < frag_numkeys; i++) {
lp[i] = reinterpret_cast<const uint64_t *>(fragments[i].data());
}
- memcpy(frag_res.get(), fragments[0].data(), frag_minlen);
+ if (op_flag != kBitOpDiff && op_flag != kBitOpDiff1 && op_flag !=
kBitOpAndOr) {
Review Comment:
I implemented this based on the Redis solution:
https://github.com/redis/redis/pull/13898
However, the results are different. I've been looking for the cause but
haven't found it yet. I'm not sure if I've overlooked something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
