zhixinwen opened a new pull request, #3220: URL: https://github.com/apache/kvrocks/pull/3220
In the old code, we only ack when there is data written and `sendReplConfAck` would only send ack if not ack was sent in the last 1 sec. This works fine for continuous traffic. However, if write stops and the last write did not trigger an ack due to 1s rate limit, no more ack would be sent. If user runs `INFO replication` on master, the user would see a replication lag that never get catch up. In this PR we send ack back whenever replication sees ping, because ping is only sent when master has no data, this should not add extra load. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
