git-hulk commented on code in PR #3240:
URL: https://github.com/apache/kvrocks/pull/3240#discussion_r2484151430
##########
src/cluster/slot_migrate.cc:
##########
@@ -1272,12 +1318,11 @@ Status SlotMigrator::sendSnapshotByRawKV() {
auto no_txn_ctx = engine::Context::NoTransactionContext(storage_);
engine::DBIterator iter(no_txn_ctx, read_options);
- BatchSender batch_sender(*dst_fd_, migrate_batch_size_bytes_,
migrate_batch_bytes_per_sec_);
+ BatchSender batch_sender(fd, migrate_batch_size_bytes_,
migrate_batch_bytes_per_sec_ / parallelism);
Review Comment:
`migrate_batch_bytes_per_sec_ / parallelism`, this might affect the
migration performance when the keys exist in a few slots. The better way is to
share a global rate limiter between threads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
