PragmaTwice commented on PR #3245:
URL: https://github.com/apache/kvrocks/pull/3245#issuecomment-3478125720
> Hi, I reviewed the linter logs, and I noticed that the errors are in the
files I didn't modify as part of my PR. I'm a bit stuck with these errors.
Could anyone help me understand this?
Related CI logs are here:
```
/home/runner/work/kvrocks/kvrocks/src/commands/cmd_timeseries.cc:1064:27:
error: invalid case style for private method 'execute_command'
[readability-identifier-naming,-warnings-as-errors]
986 | virtual rocksdb::Status execute_command(engine::Context &ctx,
TimeSeries &ts, std::vector<TSMRangeResult> *results) {
| ^~~~~~~~~~~~~~~
| executeCommand
987 | return ts.MRange(ctx, option_, results);
988 | }
989 | };
990 |
991 | class CommandTSMRevRange : public CommandTSMRange {
992 | public:
993 | CommandTSMRevRange() = default;
994 |
995 | private:
996 | rocksdb::Status execute_command(engine::Context &ctx, TimeSeries
&ts, std::vector<TSMRangeResult> *results) override {
| ~~~~~~~~~~~~~~~
| executeCommand
```
So it's about naming of your newly-added method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
