donghao526 commented on code in PR #3130:
URL: https://github.com/apache/kvrocks/pull/3130#discussion_r2485673042
##########
src/commands/cmd_tdigest.cc:
##########
@@ -176,6 +176,54 @@ class CommandTDigestAdd : public Commander {
std::vector<double> values_;
};
+class CommandTDigestRevRank : public Commander {
+ public:
+ Status Parse(const std::vector<std::string> &args) override {
+ key_name_ = args[1];
+
+ std::unordered_set<std::string> unique_inputs_set(args.begin() + 2,
args.end());
Review Comment:
@LindaSummer Yeah, std::set is ok.
This is my first PR for a large project, and I've learned a lot. Thank
you.😊.
##########
src/commands/cmd_tdigest.cc:
##########
@@ -176,6 +176,54 @@ class CommandTDigestAdd : public Commander {
std::vector<double> values_;
};
+class CommandTDigestRevRank : public Commander {
+ public:
+ Status Parse(const std::vector<std::string> &args) override {
+ key_name_ = args[1];
+
+ std::unordered_set<std::string> unique_inputs_set(args.begin() + 2,
args.end());
Review Comment:
@LindaSummer Yeah, std::set is ok.
This is my first PR for a large project, and I've learned a lot. Thank you😊.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
