git-hulk commented on code in PR #3248:
URL: https://github.com/apache/kvrocks/pull/3248#discussion_r2497193203
##########
src/cluster/replication.cc:
##########
@@ -214,7 +214,8 @@ void FeedSlaveThread::loop() {
// kMaxDelayUpdates than latest sequence.
if (is_first_repl_batch || batches_bulk.size() >= max_delay_bytes_ ||
updates_in_batches >= max_delay_updates_ ||
srv_->storage->LatestSeqNumber() - batch.sequence <=
max_delay_updates_) {
- if (shouldSendGetAck(batch.sequence)) {
+ // get the last sequence number of the batch, because WAIT uses the last
sequence number to wake up the connection.
Review Comment:
```suggestion
// get the last sequence number of the batch, because WAIT uses
// the last sequence number to wake up the connection.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
