PragmaTwice commented on PR #3255: URL: https://github.com/apache/kvrocks/pull/3255#issuecomment-3515872055
In general I'm not in favor of the `FetchContent` with `find_package` way. This is a huge change that will affect to other distros. I treat this issue as: currently we cannot build kvrocks in an offline environment. And nix is only a special case of it. I've considered this problem and have some solutions, but I haven't had the time to implement them yet. I'll dive into this issue recently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
