LindaSummer commented on code in PR #3261:
URL: https://github.com/apache/kvrocks/pull/3261#discussion_r2529700206


##########
.github/workflows/kvrocks.yaml:
##########
@@ -272,6 +283,7 @@ jobs:
           sudo mkdir -p $RISCV_PATH
           wget "${{ matrix.riscv_toolchain_url }}" -O riscv-toolchain.tar.xz
           sudo tar -xvf riscv-toolchain.tar.xz -C $RISCV_PATH 
--strip-components=1
+          rm riscv-toolchain.tar.xz

Review Comment:
   ```suggestion
             wget -qO- "${{ matrix.riscv_toolchain_url }}" | sudo tar -Jxv -C 
$RISCV_PATH --strip-components=1
   ```
   
   Hi @PragmaTwice ,
   
   Maybe this on-the-fly way would reduce the temp storage during wget and 
wouldn't leave the file in filesystem if the tarball is crashed. 😊
   
   Best Regards,
   Edward



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to