yezhizi commented on code in PR #3264:
URL: https://github.com/apache/kvrocks/pull/3264#discussion_r2536349098
##########
tests/cppunit/types/timeseries_test.cc:
##########
@@ -53,6 +53,40 @@ TEST_F(TimeSeriesTest, Create) {
EXPECT_EQ(s.ToString(), "Invalid argument: key already exists");
}
+TEST_F(TimeSeriesTest, Alter) {
Review Comment:
Could you add more tests in `timeseries_test.cc` to:
1. After changing chunk_size, using `ts.add/madd` to add some samples,
ensure the correctness of the sample addition results.
Like this:
https://github.com/var-nan/kvrocks/blob/bede988e12fa2c6d0a5d90ca762b52ba88e0c827/tests/cppunit/types/timeseries_test.cc#L90-L103
2. Validate label updates: Alter labels and use `ts.queryindex` to filter
time series, confirming that TSRevLabelKey is properly updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
