i18nsite commented on PR #3283: URL: https://github.com/apache/kvrocks/pull/3283#issuecomment-3594652195
我的几点个人意见 1. 现在 x.py 运行的帮助提示很不清楚，很多人可能没有看那个文档就直接运行，不知道有这种用法 这个合并请求，让用法更加清楚 <img width="590" height="496" alt="image" src="https://github.com/user-attachments/assets/bb61a3b6-e9fa-49c6-a935-7f23683cc22a"; /> 2. ./x.py test stream/stream_test.go 这种用法 比./x.py test go <BUILD_DIR> -run <PATTERN> 看起来更加直接 我测试了一下`./x.py test go ./build -run TestStream`, 貌似还是运行了一堆乱七八糟的测试？没法运行某个文件的测试？ ``` ❯ ./x.py test go ./build -run TestStream $ /Users/z/.local/share/mise/installs/go/1.25.4/bin/go test -timeout=1800s -bench=. ./... -binPath=/Users/z/git/kvrocks/kvrocks/build/kvrocks -cliPath=redis-cli -workspace=/Users/z/git/kvrock s/kvrocks/tests/gocase/workspace -run TestStream PASS ok github.com/apache/kvrocks/tests/gocase/integration/cli 0.015s PASS ok github.com/apache/kvrocks/tests/gocase/integration/cli_options 0.014s PASS ok github.com/apache/kvrocks/tests/gocase/integration/cluster 0.014s PASS ok github.com/apache/kvrocks/tests/gocase/integration/replication 0.010s PASS ok github.com/apache/kvrocks/tests/gocase/integration/rsid 0.009s ``` <img width="1917" height="590" alt="image" src="https://github.com/user-attachments/assets/4132c4ff-4a1f-4990-81a8-3e60a66d5c75"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
