Copilot commented on code in PR #370:
URL:
https://github.com/apache/kvrocks-controller/pull/370#discussion_r2597885527
##########
webui/tsconfig.json:
##########
@@ -15,30 +15,44 @@
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
- */ {
- "compilerOptions": {
- "lib": ["dom", "dom.iterable", "esnext"],
- "allowJs": true,
- "skipLibCheck": true,
- "strict": true,
- "noEmit": true,
- "esModuleInterop": true,
- "module": "esnext",
- "moduleResolution": "bundler",
- "resolveJsonModule": true,
- "isolatedModules": true,
- "jsx": "preserve",
- "incremental": true,
- "plugins": [
- {
- "name": "next"
- }
- ],
- "paths": {
- "@/*": ["./src/*"]
- },
- "target": "ES2017"
+ */{
+ "compilerOptions": {
+ "lib": [
+ "dom",
+ "dom.iterable",
+ "esnext"
+ ],
+ "allowJs": true,
+ "skipLibCheck": true,
+ "strict": true,
+ "noEmit": true,
+ "esModuleInterop": true,
+ "module": "esnext",
+ "moduleResolution": "bundler",
+ "resolveJsonModule": true,
+ "isolatedModules": true,
+ "jsx": "react-jsx",
Review Comment:
The JSX compiler option has been changed from "preserve" to "react-jsx". For
Next.js projects using the App Router (which this project appears to use based
on the src/app directory structure), the recommended setting is "preserve" to
let Next.js handle JSX transformation. Changing to "react-jsx" may cause
compatibility issues with Next.js features like Server Components. Please
verify this change is intentional and compatible with the upgraded Next.js
version.
```suggestion
"jsx": "preserve",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
