git-hulk commented on code in PR #3294:
URL: https://github.com/apache/kvrocks/pull/3294#discussion_r2617972373
##########
src/config/config.cc:
##########
@@ -892,8 +891,8 @@ Status Config::finish() {
if ((cluster_enabled) && !load_tokens.empty()) {
return {Status::NotOK, "enabled cluster mode wasn't allowed while the
namespace exists"};
}
- if ((redis_select_compatible) && !load_tokens.empty()) {
- return {Status::NotOK, "redis-select-compatible mode wasn't allowed while
the namespace exists"};
+ if ((redis_databases > 0) && !load_tokens.empty()) {
Review Comment:
@hanxi You can also check if `cluster_enabled` is enabled here. If enabled,
redis database feture should be also disasllowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
