PragmaTwice commented on code in PR #3294:
URL: https://github.com/apache/kvrocks/pull/3294#discussion_r2625413784
##########
src/config/config.cc:
##########
@@ -233,6 +233,7 @@ Config::Config() {
{"log-retention-days", true, new IntField(&log_retention_days, -1, -1,
INT_MAX)},
{"persist-cluster-nodes-enabled", false, new
YesNoField(&persist_cluster_nodes_enabled, true)},
{"redis-cursor-compatible", false, new
YesNoField(&redis_cursor_compatible, true)},
+ {"redis-databases", true, new IntField(&redis_databases, 0, 0, 10000)},
Review Comment:
> Should we change them to db1 instead?
yup. regardless of there's a prefix or not. it's alphabetical order in
rocksdb and we cannot iterate from db1 to dbN in integer order. cc @git-hulk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
