git-hulk commented on code in PR #345: URL: https://github.com/apache/kvrocks-website/pull/345#discussion_r2633356272
########## docs/supported-commands.md: ########## @@ -376,8 +376,7 @@ To guarantee the correctness of client SDK, we rename the `CLUSTER` command to ` The response of `DBSIZE` and keyspace section of `INFO` is updated asynchronously after executing `DBSIZE SCAN` command. -In Kvrocks the `SELECT` command is just a placeholder and does not switch between dbs. -Use [the namespace feature](https://kvrocks.apache.org/docs/namespace) instead if multiple dbs are needed. +The `SELECT` command is a placeholder by default (`redis-databases = 0`). When `redis-databases` > 0, it switches between databases (0 to redis-databases-1). Database 0 uses the default namespace, databases 1-N use `db1`, `db2`, etc. Enabling this disables custom namespaces. Use [the namespace feature](https://kvrocks.apache.org/docs/namespace) for multiple isolated databases without `redis-databases`. Review Comment: ```suggestion In Kvrocks the `SELECT` command is just a placeholder and does not switch between dbs if the `redis-database` is not enabled(`redis-databases = 0` by default). A [the namespace feature](https://kvrocks.apache.org/docs/namespace) instead if multiple dbs are needed. Before [NEXT RELEASE VERSION], Kvrocks only allowed using [the namespace feature](https://kvrocks.apache.org/docs/namespace) to isolate your data. That said, the `SELECT` command is just a placeholder and does not switch between databases. And now, the Redis database mechanism is supported, and you can enable it by setting the `redis-database` to the database number you expect in the configuration file. To be noticed, we don't allow using the namespace feature and the Redis database at the same time. ########## docs/supported-commands.md: ########## @@ -335,7 +335,7 @@ To guarantee the correctness of client SDK, we rename the `CLUSTER` command to ` | BGSAVE | ✓ | v1.0.0 | Initiates a background save of the dataset to disk. | | LASTSAVE | ✓ | v2.6.0 | Returns the timestamp of the last successful save to disk. Additionally, `LASTSAVE ISO8601` returns the time in ISO8601 format. | | PING | ✓ | v1.0.0 | Checks if the server is alive, responding with "PONG." | -| SELECT | ✓ | v1.0.0 | simply returns OK. | +| SELECT | ✓ | unstable | Switches between databases when `redis-databases` > 0 (default 0: returns OK without switching). | Review Comment: ```suggestion | SELECT | ✓ | v1.0.0 | Switches between databases when `redis-databases` > 0 (default 0: returns OK without switching) since [NEXT RELEASE VERSION]. | ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
