git-hulk commented on code in PR #3313:
URL: https://github.com/apache/kvrocks/pull/3313#discussion_r2649155743
##########
tests/gocase/unit/type/string/digest_test.go:
##########
@@ -0,0 +1,158 @@
+package string
+
+import (
+ "context"
+ "testing"
+
+ "github.com/stretchr/testify/require"
+
+ "github.com/apache/kvrocks/tests/gocase/util"
+)
+
+func TestDigest(t *testing.T) {
+ srv := util.StartServer(t, map[string]string{})
+ defer srv.Close()
+ ctx := context.Background()
+ rdb := srv.NewClient()
+ defer func() { require.NoError(t, rdb.Close()) }()
+
+ t.Run("DIGEST with existing string key", func(t *testing.T) {
+ require.NoError(t, rdb.Set(ctx, "key1", "Hello world", 0).Err())
+
+ // DIGEST should return hex hash
+ digest := rdb.Do(ctx, "DIGEST", "key1").Val()
+ require.NotNil(t, digest)
+
+ // Result should be a string with 16 hex characters
+ digestStr, ok := digest.(string)
+ require.True(t, ok)
+ require.Len(t, digestStr, 16)
+
+ // Verify it contains only valid hex characters
+ for _, c := range digestStr {
+ require.True(t, (c >= '0' && c <= '9') || (c >= 'a' &&
c <= 'f'))
+ }
+ })
+
+ t.Run("DIGEST with non-existent key", func(t *testing.T) {
+ // DIGEST should return nil for non-existent key
+ digest := rdb.Do(ctx, "DIGEST", "nonexistent").Val()
+ require.Nil(t, digest)
+ })
+
+ t.Run("DIGEST with different string values produces different hashes",
func(t *testing.T) {
+ require.NoError(t, rdb.Set(ctx, "key1", "Hello", 0).Err())
+ require.NoError(t, rdb.Set(ctx, "key2", "World", 0).Err())
+
+ digest1 := rdb.Do(ctx, "DIGEST", "key1").Val().(string)
+ digest2 := rdb.Do(ctx, "DIGEST", "key2").Val().(string)
+
+ require.NotEqual(t, digest1, digest2)
+ })
+
+ t.Run("DIGEST with same string value produces same hash", func(t
*testing.T) {
+ require.NoError(t, rdb.Set(ctx, "key1", "consistent", 0).Err())
+ require.NoError(t, rdb.Set(ctx, "key2", "consistent", 0).Err())
+
+ digest1 := rdb.Do(ctx, "DIGEST", "key1").Val().(string)
+ digest2 := rdb.Do(ctx, "DIGEST", "key2").Val().(string)
+
+ require.Equal(t, digest1, digest2)
+ })
+
+ t.Run("DIGEST with empty string", func(t *testing.T) {
+ require.NoError(t, rdb.Set(ctx, "empty", "", 0).Err())
+
+ digest := rdb.Do(ctx, "DIGEST", "empty").Val()
+ require.NotNil(t, digest)
+
+ // Should still return a valid hex string
+ digestStr := digest.(string)
+ require.Len(t, digestStr, 16)
+ })
+
+ t.Run("DIGEST with binary data", func(t *testing.T) {
+ binaryData := "\x00\x01\x02\xff\xfe\xfd"
+ require.NoError(t, rdb.Set(ctx, "binary", binaryData, 0).Err())
+
+ digest := rdb.Do(ctx, "DIGEST", "binary").Val()
+ require.NotNil(t, digest)
+
+ digestStr := digest.(string)
+ require.Len(t, digestStr, 16)
+ })
+
+ t.Run("DIGEST with large string", func(t *testing.T) {
+ // Create a large string
+ largeString := make([]byte, 10240)
+ for i := range largeString {
+ largeString[i] = byte(i % 256)
+ }
+
+ require.NoError(t, rdb.Set(ctx, "large", string(largeString),
0).Err())
+
+ digest := rdb.Do(ctx, "DIGEST", "large").Val()
+ require.NotNil(t, digest)
+
+ digestStr := digest.(string)
+ require.Len(t, digestStr, 16)
+ })
+
+ t.Run("DIGEST wrong number of arguments", func(t *testing.T) {
+ // Too few arguments
+ err := rdb.Do(ctx, "DIGEST").Err()
+ require.Error(t, err)
+ require.Contains(t, err.Error(), "wrong number of arguments")
+
+ // Too many arguments
+ err = rdb.Do(ctx, "DIGEST", "key1", "extra").Err()
+ require.Error(t, err)
+ require.Contains(t, err.Error(), "wrong number of arguments")
+ })
+
+ t.Run("DIGEST with wrong key type should fail", func(t *testing.T) {
+ // Set up a non-string key
+ require.NoError(t, rdb.LPush(ctx, "list_key", "value").Err())
+
+ // DIGEST should fail on non-string keys
+ err := rdb.Do(ctx, "DIGEST", "list_key").Err()
+ require.Error(t, err)
+ require.Contains(t, err.Error(), "WRONGTYPE")
+ })
+}
+
+func TestDigestCompatibility(t *testing.T) {
+ srv := util.StartServer(t, map[string]string{})
+ defer srv.Close()
+ ctx := context.Background()
+ rdb := srv.NewClient()
+ defer func() { require.NoError(t, rdb.Close()) }()
+
+ // Test compatibility with Redis command syntax
+ testCases := []struct {
+ name string
+ value string
+ expected string
+ }{
+ {"simple string", "hello", ""},
+ {"number as string", "123", ""},
+ {"special chars", "!@#$%^&*()", ""},
+ {"unicode", "こんにちは", ""},
+ }
+
+ for _, tc := range testCases {
+ t.Run(tc.name, func(t *testing.T) {
+ require.NoError(t, rdb.Set(ctx, "test_key", tc.value,
0).Err())
+
+ digest := rdb.Do(ctx, "DIGEST", "test_key").Val()
+ require.NotNil(t, digest)
+
+ digestStr := digest.(string)
+ require.Len(t, digestStr, 16)
+
+ if tc.expected != "" {
+ require.Equal(t, tc.expected, digestStr)
+ }
+ })
+ }
+}
Review Comment:
```suggestion
}
```
##########
src/commands/cmd_string.cc:
##########
@@ -721,10 +723,47 @@ class CommandLCS : public Commander {
int64_t min_match_len_ = 0;
};
+class CommandDigest : public Commander {
+ public:
+ Status Parse(const std::vector<std::string> &args) override {
+ if (args.size() != 2) {
+ return {Status::RedisParseErr, errWrongNumOfArguments};
+ }
+ return Commander::Parse(args);
+ }
Review Comment:
There is no need since we have specified the number of expected arguments
while registering the command.
```suggestion
```
##########
tests/gocase/unit/type/string/digest_test.go:
##########
@@ -0,0 +1,158 @@
+package string
+
+import (
+ "context"
+ "testing"
+
+ "github.com/stretchr/testify/require"
+
+ "github.com/apache/kvrocks/tests/gocase/util"
+)
+
+func TestDigest(t *testing.T) {
+ srv := util.StartServer(t, map[string]string{})
+ defer srv.Close()
+ ctx := context.Background()
+ rdb := srv.NewClient()
+ defer func() { require.NoError(t, rdb.Close()) }()
+
+ t.Run("DIGEST with existing string key", func(t *testing.T) {
+ require.NoError(t, rdb.Set(ctx, "key1", "Hello world", 0).Err())
+
+ // DIGEST should return hex hash
+ digest := rdb.Do(ctx, "DIGEST", "key1").Val()
Review Comment:
Can use the `String` to avoid the typecast. The same as other places.
```suggestion
digest := rdb.Do(ctx, "DIGEST", "key1").String()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
