PragmaTwice commented on code in PR #3318:
URL: https://github.com/apache/kvrocks/pull/3318#discussion_r2656177325


##########
src/types/redis_string.cc:
##########
@@ -393,46 +393,71 @@ rocksdb::Status String::IncrByFloat(engine::Context &ctx, 
const std::string &use
   return updateRawValue(ctx, ns_key, raw_value);
 }
 
-rocksdb::Status String::MSet(engine::Context &ctx, const 
std::vector<StringPair> &pairs, uint64_t expire_ms) {
+rocksdb::Status String::MSet(engine::Context &ctx, const 
std::vector<StringPair> &pairs, StringMSetArgs args,
+                             bool *flag) {
+  if (flag != nullptr) {

Review Comment:
   Good to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to