PragmaTwice commented on PR #3327:
URL: https://github.com/apache/kvrocks/pull/3327#issuecomment-3717886789
I should note that this structure is wrong in transaction mode:
```c++
for (...) {
if (..) return ..;
batch->Put(...)
}
batch->Commit()
```
because if early returns happen, in transaction mode we will still commit
this batch in EXEC command.
But this is not introduced in this PR, so I'm fine to merge. It can be fixed
later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
