sryanyuan commented on PR #3340: URL: https://github.com/apache/kvrocks/pull/3340#issuecomment-3747326688
> @sryanyuan Thanks for your PR. I know it's a good point for avoiding unnecessary full syncs in some scenarios, but my concern is that it might cause long-term inconsistency between the master and the replica, even in the metadata and its fields. > > For instance, the master has a not-yet-replicated command `HSET hash f0 v0`, and we use the padding sequence to replace it. Aside from the inconsistency between the master and replica, it also has inconsistent HASH metadata and fields if we continue appending new fields to this hash key. > > cc @PragmaTwice @torwig @caipengbo Thanks for pointing this out — you’re right, skipping WriteBatch entries via sequence padding can lead to long-term inconsistencies not only in the actual data but also in metadata like hash length 🥲 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
