Kaustubh1204 commented on PR #373: URL: https://github.com/apache/kvrocks-controller/pull/373#issuecomment-3774315482
Hi @git-hulk, thanks for reviewing! The build error occurred because the method promoteNewMaster was defined in its module but was not exported. When other parts of the code tried to import it, the build failed with an error like “undefined” or “cannot find module export.” By exporting it as PromoteNewMaster, it can now be properly imported and used across the codebase, which resolves the build failure. Additionally, the failover validation logic was updated to allow sequence == 0 when the current master’s sequence is also 0. This addresses the issue reported by @original-author in #366 (“Failover failed because of sequence is 0”), where failover would fail for empty shards. Now, the failover process can correctly handle cases where both the current master and the new master have a sequence of 0. These two changes together ensure that the build succeeds and that failover behaves correctly in all edge cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
