dashjay commented on code in PR #3346:
URL: https://github.com/apache/kvrocks/pull/3346#discussion_r2730137152


##########
src/storage/redis_db.h:
##########
@@ -182,6 +182,17 @@ class SubKeyScanner : public redis::Database {
   rocksdb::Status Scan(engine::Context &ctx, RedisType type, const Slice 
&user_key, const std::string &cursor,
                        uint64_t limit, const std::string &subkey_prefix, 
std::vector<std::string> *keys,
                        std::vector<std::string> *values = nullptr);
+  std::string GetSubKeyExpireInternalKey(const Slice &user_key, const Slice 
&hash_field, uint64_t metadata_version);
+  // Get expire timestamp in milliseconds for a field
+  // expire_at:
+  // 0 (NoExpireTime) if field has no associated expiration.
+  // A non-negative value representing the expire timestamp in milliseconds.
+  [[nodiscard]] rocksdb::Status GetSubKeyExpireTimestampMS(engine::Context 
&ctx, const Slice &user_key,
+                                                           const Slice 
&hash_field, uint64_t metadata_version,
+                                                           uint64_t 
*expired_at);
+  void MGetSubKeyExpireTimestampMS(engine::Context &ctx, const Slice 
&user_key, const std::vector<Slice> &hash_fields,

Review Comment:
   this three function define in SubKeyScanner but only used in hash for now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to