Kaustubh1204 commented on PR #374: URL: https://github.com/apache/kvrocks-controller/pull/374#issuecomment-3855492288
This PR fully resolves **Issue #329: Split-Brain Vulnerability** in kvrocks-controller. ### Key Fixes: 1. **Reliable Failure Detection**: `probeNode()` performs quorum verification to prevent false-positive failovers. 2. **Node Fencing**: `promoteNewMaster()` explicitly demotes the old master before promoting a new one. 3. **Conditional Store Writes**: `UpdateCluster()` enforces leader lease validation to block Zombie Controllers. 4. **Atomic Failover Flow**: Promotion and persistence are sequenced to prevent irreversible split-brain points. ### Verification: - Specialized unit tests (`split_brain_test.go`) confirm Zombie Controllers are blocked and quorum checks work. - Existing cluster tests updated and passing. - All critical safety invariants are enforced, preventing both control-plane and data-plane split-brain scenarios. **Closes #329** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
