git-hulk commented on code in PR #3366:
URL: https://github.com/apache/kvrocks/pull/3366#discussion_r2780488231
##########
src/storage/rdb/rdb.cc:
##########
@@ -930,6 +954,21 @@ Status RDB::SaveHashObject(const std::vector<FieldValue>
&field_values) {
}
return Status::OK();
}
+Status RDB::SaveSortedintObject(const std::vector<uint64_t> &ids) {
+ if (ids.size() > 0) {
+ auto status = RdbSaveLen(ids.size());
+ if (!status.IsOK()) return status;
+
+ for (const auto &id : ids) {
+ status = SaveStringObject(std::to_string(id));
+ if (!status.IsOK()) return status;
+ }
+ } else {
+ WARN("the size of sortedint is zero");
+ return {Status::NotOK, "the size of sortedint is zero"};
Review Comment:
```suggestion
return {Status::NotOK, "the size of sortedint is zero"};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]