Kaustubh1204 opened a new pull request, #381:
URL: https://github.com/apache/kvrocks-controller/pull/381
## Summary
This PR resolves CI typecheck failures caused by missing `MigrationTask`
type definitions during Linux builds.
The issue was likely due to filesystem case-sensitivity inconsistencies
affecting `store/migration.go`, which resulted in `undefined: MigrationTask`
errors in CI.
## Changes
- Consolidated `MigrationTask` and `MigrationTaskStatus` definitions into
`store/cluster.go`
- Removed `store/migration.go` to eliminate casing ambiguity
- Added `store/migration_types_test.go` with regression tests covering:
- `MigrationTaskStatus.String()` behavior
- JSON marshaling/unmarshaling of `MigrationTask`
- `Cluster` integration and deep-copy behavior
## Validation
- `go build ./...` passes
- `go test ./...` passes (excluding environment-dependent integration tests)
- `golangci-lint` passes
- No business logic removed (verified `migration.go` contained only type
definitions)
## Impact
- Fixes CI typecheck failure
- Improves cross-platform determinism
- Adds regression protection for future changes to migration types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
