Kaustubh1204 commented on issue #329: URL: https://github.com/apache/kvrocks-controller/issues/329#issuecomment-3885059847
Hi @Allen315, @git-hulk, I’ve worked on fixing the split-brain issue (#329) and updated the workflow in .github/workflows/build.yml to safely handle fork PRs. The fix strengthens leadership guarantees and ensures that only the true leader can promote a master. The changes have been committed and referenced in PR #374. CI Status: Build: Passed License check: Failed for controller/split_brain_test.go. This file is missing a valid license header and existed prior to my PR. Lint/tests: Some lint issues may appear due to outdated .golangci.yml config in the repo; unrelated to my changes. Next Steps: Maintainers can fix the license header in split_brain_test.go. My workflow and split-brain logic are safe to merge, as Go build passes and workflow syntax is valid. Please review the PR when convenient. I’m happy to assist with license or lint updates if needed. Thanks, Kaustubh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
