Paragrf commented on code in PR #389:
URL:
https://github.com/apache/kvrocks-controller/pull/389#discussion_r3226304556
##########
config/config.go:
##########
@@ -47,6 +47,7 @@ type FailOverConfig struct {
// propagates the updated topology. Requires kvrocks to support node
status
// modification (new versions only). Defaults to false for backward
compatibility.
EnableSlaveHAUpdate bool `yaml:"enable_slave_ha_update"`
+ WaitForSync bool `yaml:"wait_for_sync"`
Review Comment:
Sorry about that—this parameter is actually for active master switching, not
passive. The idea was to use it alongside options.wait_for_sync: if it's true
in the config, we use that; if false, we follow the request options. It exists
mainly to support legacy servers since CLIENT PAUSE is only available in the
latest versions. I've fixed the error now. Thanks for catching that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
