Paragrf commented on PR #389: URL: https://github.com/apache/kvrocks-controller/pull/389#issuecomment-4495604658
> > > > if we immediately trigger a _getack command on the server side upon receiving INFO replication, it will force the slave to report its current seq right away. > > > > > > > > > We shouldn't let the `INFO` command do this. > > > > > > @git-hulk OK,How about adding an asynchronous probe in the controller to expose a slave lag metric for better monitoring accuracy? > > Yes, it would be better to do this in the controller. It can sync the lag between nodes before failover. OK, how about we merge this for now? It's already handled this way in the failover logic of this commit. The discussion here is only about the slave lag metric, which we can always add later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
