nagisa-kunhah commented on PR #3481: URL: https://github.com/apache/kvrocks/pull/3481#issuecomment-4515752542
@jihuayu Hi, I'm ready for the next round of review. Here's a summary of the changes since last time: - Decoupled CuckooPageCache from CuckooChainMetadata — it now takes scalar parameters (bucket_size, page_size) instead of holding a reference to the metadata struct. - Refactored CuckooSubFilter — removed the metadata_ member; construction takes only the fields it needs. - Moved CalculateFilterCapacity and GetFilterNumBuckets to CuckooFilterHelper — these are now static methods, making them independently testable and decoupled from the chain implementation. - Expanded Go integration tests from 3 to 16 test cases covering edge cases (zero capacity, large capacity, expansion, full filter behavior, etc.). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
