Abhinav2656 opened a new pull request, #3500:
URL: https://github.com/apache/kvrocks/pull/3500

   **Resolves:**  #3231
   
   **What this PR does / why we need it:**
   This PR removes the restrictions that previously prevented the use of 
multiple namespaces and numbered databases when cluster mode is enabled. 
   
   Specifically, it:
   * Removes the `kErrClusterModeEnabled` rejection logic in 
`src/server/namespace.cc` to allow namespace creation and modification under 
cluster mode.
   * Removes the configuration initialization guards in `src/config/config.cc` 
that forced a failure when both `cluster_enabled` and namespace 
tokens/databases were present.
   * Ensures namespace configurations are correctly written to the persistent 
store regardless of the cluster state by removing the early return block.
   
   **Brief test explanation:**
   * Re-compiled successfully with native C++ tests passing.
   * Executed and passed the Go integration tests specifically for 
`unit/namespace` (`go test ./unit/namespace ...`) under the `tests/gocase` 
suite.
   
   Please let me know if any architectural adjustments are required. I am fully 
open to your review and stand ready to iterate on this logic as needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to