git-hulk opened a new pull request, #3531: URL: https://github.com/apache/kvrocks/pull/3531
## Summary - `WaitForSync` currently only allows 5s for `master_link_status` to reach `up`, which is not enough on loaded CI runners (notably the SonarCloud coverage build). - Extend the wait so the `resume_broken_transfer_based_files` subtest stops failing intermittently while the slave is still catching up. ## CI failure - Run: https://github.com/apache/kvrocks/actions/runs/27660686644 - Failing job (SonarCloud with Coverage): https://github.com/apache/kvrocks/actions/runs/27660686644/job/81804342125 - Symptom: `--- FAIL: TestReplicationWithLimitSpeed/resume_broken_transfer_based_files` — `Condition never satisfied` at `tests/gocase/integration/replication/replication_test.go:362` (via `util/client.go:50`). ## Reproduction Reproduced locally on macOS by running 16 background CPU burners and looping the test: ``` for i in $(seq 1 6); do go test -count=1 -run TestReplicationWithLimitSpeed$ \ ./integration/replication/... \ -binPath=.../build/kvrocks -workspace=/tmp/kvrocks-test-ws done ``` - Before the fix: 1/6 runs failed with the same trace as the CI flake. - After the fix: 8/8 runs pass under the same CPU load (run times 34-51s vs. an unloaded baseline of ~28s, confirming load was active). ## Test plan - [x] `TestReplicationWithLimitSpeed` passes 8/8 locally under sustained 16-core CPU load. - [ ] CI green on this PR, including the SonarCloud coverage build that produced the original failure. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
