git-hulk commented on code in PR #3536:
URL: https://github.com/apache/kvrocks/pull/3536#discussion_r3456943128
##########
src/server/server.cc:
##########
@@ -1805,16 +1805,19 @@ void Server::SlowlogPushEntryIfNeeded(const
std::vector<std::string> *args, uint
slow_log_.PushEntry(std::move(entry));
}
-std::string Server::GetClientsStr() {
+std::string Server::GetClientsStr(const redis::Connection *conn) {
std::string clients;
for (const auto &t : worker_threads_) {
- clients.append(t->GetWorker()->GetClientsStr());
+ clients.append(t->GetWorker()->GetClientsStr(conn));
}
- std::shared_lock<std::shared_mutex> guard(slave_threads_mu_);
-
- for (const auto &st : slave_threads_) {
- clients.append(st->GetConn()->ToString());
+ // Slave (replication) connections live outside any tenant namespace, so
+ // only admin (default-namespace) callers may enumerate them.
+ if (conn == nullptr || conn->IsAdmin()) {
Review Comment:
It's good to remove the nullptr check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
