nhancdt2602 commented on code in PR #3549:
URL: https://github.com/apache/kvrocks/pull/3549#discussion_r3543302968
##########
src/server/server.h:
##########
@@ -263,15 +264,30 @@ class Server {
int64_t GetLastBgsaveTime();
std::string GetRoleInfo();
+ // An INFO entry holds its value with its original type in a variant, so
each output format can
+ // render it appropriately: GetInfo emits the Redis-compatible text (e.g. a
bool as 0/1, numbers via
+ // std::to_string) while FORMAT JSON emits the native JSON type (a bool as
true/false, numbers
+ // unquoted). The type is captured here at construction, where it is
statically known.
struct InfoEntry {
+ using Value = std::variant<std::string, int64_t, uint64_t, double, bool>;
Review Comment:
Removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
