LindaSummer commented on PR #3551: URL: https://github.com/apache/kvrocks/pull/3551#issuecomment-4994371250
Hi @jihuayu , Thanks very much for your correction and review. This problem is caused by the missing of interpolation of CDF value. I have followed the redisbloom implementation and the latest patch's result should be aligned with redis now. ```txt == compressed centroids setup == $ redis-cli -h 127.0.0.1 -p 6666 TDIGEST.CREATE kvrocks_check-1:compressed COMPRESSION 10 OK == compressed centroids add 0..99 == $ redis-cli -h 127.0.0.1 -p 6666 TDIGEST.ADD kvrocks_check-1:compressed 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 OK == compressed centroids cdf, expected Redis-like: 0.205 0.405 0.505 0.605 0.805 == $ redis-cli -h 127.0.0.1 -p 6666 TDIGEST.CDF kvrocks_check-1:compressed 20 40 50 60 80 0.20499999999999999 0.40500000000000003 0.505 0.60499999999999998 0.80500000000000005 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
