git-hulk commented on PR #3560: URL: https://github.com/apache/kvrocks/pull/3560#issuecomment-5010624001
> 1. `WAIT` also replaces the bufferevent callback, but this case was missed in the current changes. It's just a wait for the replication, and should be reasonable to keep it without checking the output buffer on every OnWrite. > 2. The soft limit is not checked proactively after it expires. We seem to be missing a cron task that actively closes the connection; instead, the connection is closed lazily. Is this intentional by design? Yes, the lazy behavior is intentional behavior. > 4. Redis does not require the soft limit to be lower than the hard limit. For example, Redis accepts CONFIG SET client-output-buffer-limit "normal 1mb 2mb 10", while this PR rejects it. I prefer to keep rejecting the config explicitly instead of silence-and-ignore in Redis. And I think we don't need to fix everything that pops up from AI reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
