ishita-0301 opened a new pull request, #3561:
URL: https://github.com/apache/kvrocks/pull/3561
### What this does
`TestReplicationShareCheckpoint` runs `COMPACT` and then blindly
`time.Sleep(time.Second)` before starting the replicas. That is slower
than necessary and potentially flaky — on a loaded CI runner one second
may not be enough for the manual compaction to finish, so the test can
proceed while compaction is still running.
This replaces the fixed sleep with the same `is_compacting` poll already
used elsewhere in the same file (`TestReplicationWithHole`), returning as
soon as compaction completes:
```go
require.Eventually(t, func() bool {
return util.FindInfoEntry(masterClient, "is_compacting") == "no"
}, 10*time.Second, 100*time.Millisecond)
```
### Related
Part of #3524, addresses #3527.
### Note on testing
I was not able to run the full Go integration suite locally for this
change; it mirrors an existing, already-tested pattern in the same file
rather than introducing new behavior. Happy to adjust if maintainers
prefer a different approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
