PragmaTwice commented on code in PR #3467:
URL: https://github.com/apache/kvrocks/pull/3467#discussion_r3623251884


##########
tests/cppunit/types/cuckoo_filter_test.cc:
##########
@@ -136,6 +145,103 @@ class RedisCuckooFilterTest : public TestBase {
   std::string key_;
 };
 
+class CuckooFilterCommandTest : public TestBase {

Review Comment:
   Any reason for writing command tests in C++? Usually command-level tests are 
handled by go test cases.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to