jihuayu commented on PR #3566:
URL: https://github.com/apache/kvrocks/pull/3566#issuecomment-5079134922

   > Other parts of https://kvrocks.apache.org/community/contributing are also 
worth mention (like code style, tests .. so that it can be a general hello 
message for new people). But indeed the AI part is most important due to 
current situation.
   
   I worry that if we stress too many things, nothing will stand out. Too many 
key points are the same as having no key point at all. I would add one extra 
reminder at the end of the message.
   
   I think we could add a separate section near the beginning of **How to 
Contribute**. It could clearly explain our basic rules, what contributors must 
do, and what may cause a PR to be closed right away. This would help prevent 
important information from being missed because the document is too long.
   
   > I think we can just show this message to people with 0 merged PR in 
Kvrocks;
   
   For me, giving the reminder only once is also fine. I reminded the 
contributor three times in the PR because I wanted them to remember it and 
understand that we take this seriously. The downside is that it can feel a 
little noisy.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to