bocharov commented on PR #400:
URL:
https://github.com/apache/kvrocks-controller/pull/400#issuecomment-5185385444
@git-hulk thanks for the review — all three addressed in 1e9a79c:
1. `validateAddr` extracted and shared by `ToSlotsString` + `CheckNewNodes`.
2. `SyncClusterInfo` now takes a `SyncPolicy{MaxRetries, RetryDelay, Force}`
(with `DefaultSyncPolicy`/`ForceSyncPolicy` helpers).
3. `topologyDiverged` is now `(*store.ClusterInfo).TopologyDiverged`.
`go build`/`go vet`/`gofmt` clean; the reconcile, retry/backoff,
topology-divergence, and address-validation unit tests pass locally (the
docker-backed integration tests need the compose stack, which CI runs).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
