[
https://issues.apache.org/jira/browse/KYLIN-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052607#comment-15052607
]
hongbin ma commented on KYLIN-1209:
-----------------------------------
hi xianbin
the patch is high quality, I only have some small advices:
1. the term timeStart and timeEnd is not intuitive. In most case the start and
end of time is compared by absolute millis, so I guess you should swap the name?
2. JobTimeFilterEnum is defined as 0,1,2,4, as far as I know such convention
only helps when it is a permission enum. with no other strong reasons i think
we should not do this as it will finalize as part of REST API.
3. The new API in resource store makes some existing API no longer useful, can
we delete them? (we don't have to maintain the older version as it is not
public API)
4. it's apache style not to leave author name in the file header
> [Backend Part]Frontend display enforce timestamp filter to retrieve from
> metadata store for efficiency
> ------------------------------------------------------------------------------------------------------
>
> Key: KYLIN-1209
> URL: https://issues.apache.org/jira/browse/KYLIN-1209
> Project: Kylin
> Issue Type: Sub-task
> Reporter: hongbin ma
> Attachments: KYLIN-1209.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
