[ 
https://issues.apache.org/jira/browse/KYLIN-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367134#comment-15367134
 ] 

liyang edited comment on KYLIN-1830 at 7/8/16 2:56 AM:
-------------------------------------------------------

Thanks Richard!

Note there is {{bin/get-properties.sh}} that is also capable of reading 
kylin.properties. We shall keep one implementation and stick to it.


was (Author: [email protected]):
Note there is {{bin/get-properties.sh}} that is also capable of reading 
kylin.properties. 

> Put KYLIN_JVM_SETTINGS to kylin.properties
> ------------------------------------------
>
>                 Key: KYLIN-1830
>                 URL: https://issues.apache.org/jira/browse/KYLIN-1830
>             Project: Kylin
>          Issue Type: Improvement
>            Reporter: Richard Calaba
>            Priority: Minor
>              Labels: newbie
>         Attachments: kylin.properties, setenv.sh
>
>
> Currently is the KYLIN_JVM_SETTINGS variable stored in the ,/bin/setenv.sh 
> ... which is not wrong, but as we have also some other memory specific 
> setting in ./conf/kylin.properties file (like i.e 
> kylin.job.mapreduce.default.reduce.input.mb or kylin.table.snapshot.max_mb) 
> it might be good idea to have those performance and sizing related parameters 
> in one location.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to