[
https://issues.apache.org/jira/browse/KYLIN-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367146#comment-15367146
]
Richard Calaba commented on KYLIN-1830:
---------------------------------------
Fair enough - I had no idea so I did mine property parsing to support commented
parameters , paramteres in quotes , spliting only after 1st '=' sign, atd ...
if all this is supported by the bin/get-properties.sh then fine -> it will be
even faster as mine code scans the property every time the
export_property_override is used instead of export parameter.
It was designed this way to make the old setenv.sh and the new one very
similiar (export_property_override <name> <default> instead of export
<name>=<default>.
Also mine implementation supports specifying default value in the script so it
doesn't have to be overriden in kylin.properties file.
> Put KYLIN_JVM_SETTINGS to kylin.properties
> ------------------------------------------
>
> Key: KYLIN-1830
> URL: https://issues.apache.org/jira/browse/KYLIN-1830
> Project: Kylin
> Issue Type: Improvement
> Reporter: Richard Calaba
> Priority: Minor
> Labels: newbie
> Attachments: kylin.properties, setenv.sh
>
>
> Currently is the KYLIN_JVM_SETTINGS variable stored in the ,/bin/setenv.sh
> ... which is not wrong, but as we have also some other memory specific
> setting in ./conf/kylin.properties file (like i.e
> kylin.job.mapreduce.default.reduce.input.mb or kylin.table.snapshot.max_mb)
> it might be good idea to have those performance and sizing related parameters
> in one location.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
