[
https://issues.apache.org/jira/browse/KYLIN-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381919#comment-15381919
]
Shaofeng SHI commented on KYLIN-1894:
-------------------------------------
Hi Yerui, I applied the patch in the "v1.5.3-release" branch, and then run "mvn
test", it failed with NPE:
{code}
2016-07-18 16:42:54,917 ERROR [main TrieDictionary:182]: Not a valid value:
2016-07-18 16:42:54,917 ERROR [main TrieDictionary:182]: Not a valid value: p
2016-07-18 16:42:54,917 ERROR [main TrieDictionary:182]: Not a valid value: pa
2016-07-18 16:42:54,917 ERROR [main TrieDictionary:182]: Not a valid value: pb
2016-07-18 16:42:54,917 ERROR [main TrieDictionary:182]: Not a valid value:
parti
2016-07-18 16:42:54,917 ERROR [main TrieDictionary:182]: Not a valid value:
partz
2016-07-18 16:42:54,917 ERROR [main TrieDictionary:182]: Not a valid value:
partyz
Total 2 values
0 (0):
01234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyz
1 (1):
01234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789xyz
The length of the long string is 1136
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.735 sec - in
org.apache.kylin.dict.TrieDictionaryTest
Results :
Tests in error:
AppendTrieDictionaryTest.englishWordsTest:94->testStringDictAppend:166 »
NullPointer
AppendTrieDictionaryTest.testStringRepeatly:86->testStringDictAppend:166 »
NullPointer
AppendTrieDictionaryTest.categoryNamesTest:101->testStringDictAppend:166 »
NullPointer
Tests run: 30, Failures: 0, Errors: 3, Skipped: 1
{code}
Do I miss any commits in this branch?
> GlobalDictionary may corrupt when server suddenly crash
> -------------------------------------------------------
>
> Key: KYLIN-1894
> URL: https://issues.apache.org/jira/browse/KYLIN-1894
> Project: Kylin
> Issue Type: Improvement
> Components: Metadata
> Affects Versions: v1.5.3
> Reporter: Yerui Sun
> Assignee: Yerui Sun
> Fix For: v1.5.3
>
> Attachments: KYLIN-1894.2.patch
>
>
> Global Dictionary store data on hdfs directly, and overwrite directly when
> data file updated. If the server crashed suddenly during writing file, the
> data file may be corrupt and can't be recovered.
> To resolve this problem, copy the data file into a tmp directory and copy
> back after the file is updated successfully.
> I'll post a patch later with this solution.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
