[ 
https://issues.apache.org/jira/browse/KYLIN-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15442835#comment-15442835
 ] 

hongbin ma commented on KYLIN-1702:
-----------------------------------

Hi yanghong

consider using org.apache.kylin.metadata.model.TableDesc#getIdentity, it 
contains db name as well. This could possibly avoid another round "duplication".

Also, before merging the patch,  you have to make changes in 
org.apache.kylin.engine.mr.steps.MetadataCleanupJob to reflect your changes 
here.

> The Key of the Snapshot to the related lookup table may be not informative
> --------------------------------------------------------------------------
>
>                 Key: KYLIN-1702
>                 URL: https://issues.apache.org/jira/browse/KYLIN-1702
>             Project: Kylin
>          Issue Type: Improvement
>            Reporter: Zhong Yanghong
>            Assignee: Zhong Yanghong
>         Attachments: change_layout_path_of_table_snapshot_with_tableName.patch
>
>
> Currently the key for the snapshot stored in hbase metadata file is as 
> follows:
> ResourceStore.SNAPSHOT_RESOURCE_ROOT + "/" + new 
> File(signature.getPath()).getName() + "/" + uuid + ".snapshot"
> However, some hive tables stored in hive may organized like 
> dirName/tableName/00, dirName/tableName/01.
> Based on current setting, the key will be 
> ResourceStore.SNAPSHOT_RESOURCE_ROOT + "/" + 00 + "/" + uuid + ".snapshot", 
> which is lack of the table name information.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to