[
https://issues.apache.org/jira/browse/KYLIN-2047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dong Li resolved KYLIN-2047.
----------------------------
Resolution: Fixed
Fix Version/s: v1.6.0
> Ineffective null check in MetadataManager
> -----------------------------------------
>
> Key: KYLIN-2047
> URL: https://issues.apache.org/jira/browse/KYLIN-2047
> Project: Kylin
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Dong Li
> Priority: Minor
> Fix For: v1.6.0
>
>
> {code}
> public DataModelDesc dropModel(DataModelDesc desc) throws IOException {
> logger.info("Dropping model '" + desc.getName() + "'");
> ResourceStore store = getStore();
> if (desc != null)
> store.deleteResource(desc.getResourcePath());
> {code}
> null check for desc is done after dereference, which is ineffective.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
