[
https://issues.apache.org/jira/browse/KYLIN-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15678992#comment-15678992
]
Dayue Gao commented on KYLIN-2173:
----------------------------------
{quote}
how about the test result?
{quote}
Problem should be fixed. To avoid regressions, let me add a few test cases to
ITs.
{quote}
Besides I viewed the commit, you removed the check for empty segment, was that
related with this JIRA? The skip for empty segment was for another JIRA, are
you sure it is safe to remove that?
{quote}
Are you talking about KYLIN-1967? It's been fixed before my commit. I just
removed several duplicated log (since skipZeroInputSegment always returns
false). Please correct me if I was wrong.
{quote}
BTW, when I run "mvn clean package -DskipTests", checkstyle reported there is
unused import (see below). Please check and ensure you have checkstyle plugin
installed in IDEA:
{quote}
What a stupid mistake! Sorry for that.
> push down limit leads to wrong answer when filter is loosened
> -------------------------------------------------------------
>
> Key: KYLIN-2173
> URL: https://issues.apache.org/jira/browse/KYLIN-2173
> Project: Kylin
> Issue Type: Bug
> Components: Storage - HBase
> Affects Versions: v1.5.4.1
> Reporter: Dayue Gao
> Assignee: Dayue Gao
> Fix For: v1.6.0
>
>
> To reproduce:
> {noformat}
> select
> test_kylin_fact.cal_dt
> ,sum(test_kylin_fact.price) as GMV
> FROM test_kylin_fact
> left JOIN edw.test_cal_dt as test_cal_dt
> ON test_kylin_fact.cal_dt = test_cal_dt.cal_dt
> where test_cal_dt.week_beg_dt in ('2012-01-01', '2012-01-20')
> group by test_kylin_fact.cal_dt
> limit 12
> {noformat}
> Kylin returns 5 rows, expect 12 rows.
> Root cause: filter condition may be loosened when we translate derived filter
> in DerivedFilterTranslator. If we push down limit, query server won't get
> enough valid records from storage. In the above example, 24 rows returned
> from storage, only 5 are valid.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
